linux-kernel - Re: [PATCH wireless] brcmfmac: fix potential memory leak in brcmf_netdev_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05b2af86-2354-74b0-27b6-7c20be7d035d@huawei.com>
Date:   Thu, 17 Nov 2022 19:04:32 +0800
From:   Zhang Changzhong <zhangchangzhong@...wei.com>
To:     Kalle Valo <kvalo@...nel.org>
CC:     Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
        <linux-wireless@...r.kernel.org>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <SHA-cyfmac-dev-list@...ineon.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wireless] brcmfmac: fix potential memory leak in
 brcmf_netdev_start_xmit()

On 2022/11/17 18:09, Kalle Valo wrote:
> Zhang Changzhong <zhangchangzhong@...wei.com> writes:
> 
>> The brcmf_netdev_start_xmit() returns NETDEV_TX_OK without freeing skb
>> in case of pskb_expand_head() fails, add dev_kfree_skb() to fix it.
>>
>> Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()")
>> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> 
> I assume you have not tested this on a real device? Then it would be
> really important to add "Compile tested only" to the commit log so that
> we know it's untested.
> 

OK, I'll add "Compile tested only" to the next version and other untested
patches.

Thanks,
Changzhong