linux-kernel - Re: [PATCH] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c43f0836d741a575b4805292d6dfff134ef6225.camel@redhat.com>
Date:   Thu, 17 Nov 2022 13:13:01 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Li zeming <zeming@...china.com>, vyasevich@...il.com,
        nhorman@...driver.com, marcelo.leitner@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org
Cc:     linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sctp: sm_statefuns: Remove unnecessary
 ‘NULL’ values from Pointer

Hi,

On Tue, 2022-11-15 at 09:55 +0800, Li zeming wrote:
> The packet pointer is assigned first. It does not need to initialize the
> assignment.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

I'm sorry, but IMHO the commit message is quite unclear, I suggest to
re-phrase to something alike:

"""
The 'packet' pointer is always set in the later code, no need to
initialize it at definition time.
"""

Thanks,

Paolo