lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Nov 2022 09:42:45 +0800 From: Ye Bin <yebin@...weicloud.com> To: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org Cc: linux-kernel@...r.kernel.org, jack@...e.cz, Ye Bin <yebin10@...wei.com> Subject: [PATCH 2/3] ext4: WANR_ON when detect abnormal 'i_reserved_data_blocks' From: Ye Bin <yebin10@...wei.com> If 'i_reserved_data_blocks' is not cleared which mean something wrong with code, so emit WARN_ON to capture this abnormal closer to the first scene. Signed-off-by: Ye Bin <yebin10@...wei.com> --- fs/ext4/super.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 63ef74eb8091..30885a6fe18b 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1385,11 +1385,14 @@ static void ext4_destroy_inode(struct inode *inode) dump_stack(); } - if (EXT4_I(inode)->i_reserved_data_blocks) - ext4_msg(inode->i_sb, KERN_ERR, - "Inode %lu (%p): i_reserved_data_blocks (%u) not cleared!", - inode->i_ino, EXT4_I(inode), - EXT4_I(inode)->i_reserved_data_blocks); + if (EXT4_I(inode)->i_reserved_data_blocks) { + ext4_warning(inode->i_sb, "Inode %lu (%p): " + "i_reserved_data_blocks (%u) not cleared!", + inode->i_ino, EXT4_I(inode), + EXT4_I(inode)->i_reserved_data_blocks); + + WARN_ON(1); + } } static void init_once(void *foo) -- 2.31.1
Powered by blists - more mailing lists