linux-kernel - Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c818f6d8-94e1-5ac4-ec67-f6f872780c38@linaro.org>
Date:   Thu, 17 Nov 2022 13:58:16 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     neil.armstrong@...aro.org, Bjorn Andersson <andersson@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Amit Kucheria <amitk@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for
 sm8550

On 17/11/2022 09:06, Neil Armstrong wrote:
> Hi,
> 
> On 16/11/2022 12:26, Krzysztof Kozlowski wrote:
>> On 16/11/2022 11:09, Neil Armstrong wrote:
>>> The Qualcomm SM8550 platform has three instances of the tsens block,
>>> add a compatible for these instances.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>>> ---
>>> To: Andy Gross <agross@...nel.org>
>>> To: Bjorn Andersson <andersson@...nel.org>
>>> To: Konrad Dybcio <konrad.dybcio@...ainline.org>
>>> To: Amit Kucheria <amitk@...nel.org>
>>> To: Thara Gopinath <thara.gopinath@...il.com>
>>> To: "Rafael J. Wysocki" <rafael@...nel.org>
>>> To: Daniel Lezcano <daniel.lezcano@...aro.org>
>>> To: Zhang Rui <rui.zhang@...el.com>
>>> To: Rob Herring <robh+dt@...nel.org>
>>> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
>>> Cc: linux-arm-msm@...r.kernel.org
>>> Cc: linux-pm@...r.kernel.org
>>> Cc: devicetree@...r.kernel.org
>>> Cc: linux-kernel@...r.kernel.org
>>> ---
>>>   Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> index f0bd4b979e28..09dbd96d380e 100644
>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> @@ -58,6 +58,7 @@ properties:
>>>                 - qcom,sm8250-tsens
>>>                 - qcom,sm8350-tsens
>>>                 - qcom,sm8450-tsens
>>> +              - qcom,sm8550-tsens
>>
>> alOf:if:then should be updated.
> 
> I thought the -v2 fallback would be enough since 8450 isn't present either in the alOf:if:then either.
> 
> Anyway, will fix this.


No, you are right. The v2 fallback is already in several allOf:if:then,
so this should be fine.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof