linux-kernel - Re: [PATCH] mmc: sh_mmcif: Add check for NULL for host->chan_yx and host->chan_rx in sh_mmcif_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3Y8LvvaOQ/n7pg9@ninjato>
Date:   Thu, 17 Nov 2022 14:50:38 +0100
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Anastasia Belova <abelova@...ralinux.ru>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        Teppei Kamijou <teppei.kamijou.yb@...esas.com>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Shinya Kuribayashi <shinya.kuribayashi.px@...esas.com>,
        Chris Ball <cjb@...top.org>,
        "open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." 
        <linux-mmc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] mmc: sh_mmcif: Add check for NULL for host->chan_yx and
 host->chan_rx in sh_mmcif_end_cmd

On Thu, Nov 17, 2022 at 03:30:07PM +0300, Anastasia Belova wrote:
> Without these checks NULL-pointer may be dereferenced in
> sh_mmcif_end_cmd parameters inside if (data->flags & MMC_DATA_READ).
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Is there a code path actually triggering it? I wonder because it seems
to me the check for valid channels is already done a little above when
DMA is started. And I'd assume once DMA has been started we can take for
granted that we have a valid channel when unmapping. But maybe I am
missing some error codepath?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)