[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <166869413781.50677.10862438013473651942@Monstersaurus>
Date: Thu, 17 Nov 2022 14:08:57 +0000
From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Magnus Damm <magnus.damm@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <robert.foss@...aro.org>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
Subject: Re: [PATCH v1 3/8] clk: renesas: r8a779g0: Add display related clocks
Quoting Tomi Valkeinen (2022-11-17 12:25:42)
> From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
>
> Add clocks related to display which are needed to get the DSI output
> working.
>
> Extracted from Renesas BSP tree.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> ---
> drivers/clk/renesas/r8a779g0-cpg-mssr.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/clk/renesas/r8a779g0-cpg-mssr.c b/drivers/clk/renesas/r8a779g0-cpg-mssr.c
> index c6337a408e5e..6937f1aee677 100644
> --- a/drivers/clk/renesas/r8a779g0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a779g0-cpg-mssr.c
> @@ -145,6 +145,8 @@ static const struct cpg_core_clk r8a779g0_core_clks[] __initconst = {
> DEF_FIXED("viobusd2", R8A779G0_CLK_VIOBUSD2, CLK_VIO, 2, 1),
> DEF_FIXED("vcbus", R8A779G0_CLK_VCBUS, CLK_VC, 1, 1),
> DEF_FIXED("vcbusd2", R8A779G0_CLK_VCBUSD2, CLK_VC, 2, 1),
> + DEF_FIXED("dsiref", R8A779G0_CLK_DSIREF, CLK_PLL5_DIV4, 48, 1),
> + DEF_DIV6P1("dsiext", R8A779G0_CLK_DSIEXT, CLK_PLL5_DIV4, 0x884),
>
> DEF_GEN4_SDH("sd0h", R8A779G0_CLK_SD0H, CLK_SDSRC, 0x870),
> DEF_GEN4_SD("sd0", R8A779G0_CLK_SD0, R8A779G0_CLK_SD0H, 0x870),
> @@ -161,6 +163,14 @@ static const struct mssr_mod_clk r8a779g0_mod_clks[] __initconst = {
> DEF_MOD("avb0", 211, R8A779G0_CLK_S0D4_HSC),
> DEF_MOD("avb1", 212, R8A779G0_CLK_S0D4_HSC),
> DEF_MOD("avb2", 213, R8A779G0_CLK_S0D4_HSC),
> +
> + DEF_MOD("dis0", 411, R8A779G0_CLK_S0D3),
dsi0?
Oh - how curious - it's listed as dis0 in the datasheet.
Ok - so this is the DU *display* not DSI ;-)
> + DEF_MOD("dsitxlink0", 415, R8A779G0_CLK_DSIREF),
> + DEF_MOD("dsitxlink1", 416, R8A779G0_CLK_DSIREF),
> +
> + DEF_MOD("fcpvd0", 508, R8A779G0_CLK_S0D3),
> + DEF_MOD("fcpvd1", 509, R8A779G0_CLK_S0D3),
> +
checks out. I guess the fcpcs is the CSI related FCP ? Anyway, if it's
not needed it can be ignored for now.
> DEF_MOD("hscif0", 514, R8A779G0_CLK_SASYNCPERD1),
> DEF_MOD("hscif1", 515, R8A779G0_CLK_SASYNCPERD1),
> DEF_MOD("hscif2", 516, R8A779G0_CLK_SASYNCPERD1),
> @@ -193,6 +203,10 @@ static const struct mssr_mod_clk r8a779g0_mod_clks[] __initconst = {
> DEF_MOD("tmu3", 716, R8A779G0_CLK_SASYNCPERD2),
> DEF_MOD("tmu4", 717, R8A779G0_CLK_SASYNCPERD2),
> DEF_MOD("tpu0", 718, R8A779G0_CLK_SASYNCPERD4),
> +
> + DEF_MOD("vspd0", 830, R8A779G0_CLK_S0D1_VIO),
> + DEF_MOD("vspd1", 831, R8A779G0_CLK_S0D1_VIO),
> +
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> DEF_MOD("wdt1:wdt0", 907, R8A779G0_CLK_R),
> DEF_MOD("cmt0", 910, R8A779G0_CLK_R),
> DEF_MOD("cmt1", 911, R8A779G0_CLK_R),
> --
> 2.34.1
>
Powered by blists - more mailing lists