linux-kernel - Re: [PATCH v2 1/4] gpio: regmap: Always set gpio_chip get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57381ad0797af76838d81f44344d2085@walle.cc>
Date:   Thu, 17 Nov 2022 15:36:39 +0100
From:   Michael Walle <michael@...le.cc>
To:     William Breathitt Gray <william.gray@...aro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        robert.marko@...tura.hr, linus.walleij@...aro.org, brgl@...ev.pl,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        broonie@...nel.org
Subject: Re: [PATCH v2 1/4] gpio: regmap: Always set gpio_chip get_direction

Am 2022-11-17 15:22, schrieb William Breathitt Gray:

>> Which brings me to the question of "why this change?". The commit
>> message doesn't mention it. Just out of curiosity.
>> 
>> -michael
> 
> Currently, the 104-idi-48 module implements a get_direction() callback
> that is executed in situations such as gpiod_get_direction() which
> aren't necessarily related to sysfs. In this patch series, the
> 104-idi-48 module is migrated to the gpio_regmap API, but loses this
> get_direction() support because it's an input-only configuration. The
> purpose of this patch is to prevent that regression by supporting
> get_direction() for input-only/output-only configurations.

I see, thanks for the explanation.

As said before, I'm fine with the change and apparently we don't care
for sysfs changes ;)

-michael