linux-kernel - Re: [PATCH] MIPS: DTS: CI20: fix reset line polarity of the ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0TYJLR.I2HAAXVSWQ2D@crapouillou.net>
Date:   Fri, 18 Nov 2022 16:51:00 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: DTS: CI20: fix reset line polarity of the ethernet
 controller

Hi Dmitry,

Le ven. 18 nov. 2022 à 08:43:47 -0800, Dmitry Torokhov 
<dmitry.torokhov@...il.com> a écrit :
> The reset line is called PWRST#, annotated as "active low" in the
> binding documentation, and is driven low and then high by the driver 
> to
> reset the chip. However in device tree for CI20 board it was 
> incorrectly
> marked as "active high". Fix it.
> 
> Because (as far as I know) the ci20.dts is always built in the kernel 
> I
> elected not to also add a quirk to gpiolib to force the polarity 
> there.
> 
> Fixes: db49ca38579d ("net: davicom: dm9000: switch to using gpiod 
> API")
> Reported-by: Paul Cercueil <paul@...pouillou.net>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Thanks.

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts 
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 37c46720c719..f38c39572a9e 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -438,7 +438,7 @@ dm9000@6 {
>  		ingenic,nemc-tAW = <50>;
>  		ingenic,nemc-tSTRV = <100>;
> 
> -		reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&gpf 12 GPIO_ACTIVE_LOW>;
>  		vcc-supply = <&eth0_power>;
> 
>  		interrupt-parent = <&gpe>;
> --
> 2.38.1.584.g0f3c55d4c2-goog
> 
> 
> --
> Dmitry