linux-kernel - Re: [EXTERNAL] Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLsYkwrC-kTeL0jNQ8R0dZye3w_yvD6J_umFhhmEoLvC=j29g@mail.gmail.com>
Date:   Fri, 18 Nov 2022 11:56:09 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Md Danish Anwar <a0501179@...com>
Cc:     Rob Herring <robh@...nel.org>,
        MD Danish Anwar <danishanwar@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Suman Anna <s-anna@...com>, Roger Quadros <rogerq@...nel.org>,
        "Andrew F . Davis" <afd@...com>, nm@...com, vigneshr@...com,
        srk@...com, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [EXTERNAL] Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU
 consumer bindings

On Thu, 17 Nov 2022 at 22:49, Md Danish Anwar <a0501179@...com> wrote:
>
> Hi Mathieu,
>
> On 16/11/22 23:39, Mathieu Poirier wrote:
> > On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> >> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> >>> From: Suman Anna <s-anna@...com>
> >>>
> >>> Add DT schema binding for PRU consumers. The binding includes
> >>> all the common properties that can be used by different PRU consumer
> >>> or application nodes and supported by the PRU remoteproc driver.
> >>> These are used to configure the PRU hardware for specific user
> >>> applications.
> >>>
> >>> The application nodes themselves should define their own bindings.
> >>>
> >>> Co-developed-by: Tero Kristo <t-kristo@...com>
> >>> Co-developed-by: Suman Anna <s-anna@...com>
> >>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
> >>> Co-developed-by: Puranjay Mohan <p-mohan@...com>
> >>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> >>
> >> Run checkpatch.pl and fix the warnings with the tags.
> >
> > My bad - I asked Danish to remove the SoBs to lighten the changelog
> > presentation.  Danish, do you absolutely need to list everyone that touched that
> > patchset?  If so I suppose just listing the SoBs would be a compromise.
> >
>
> I started working on this patch series after version 5. In the first version of
> this patch series below were the tags.
>
> Co-developed-by: Tero Kristo <t-kristo@...com>
> Signed-off-by: Tero Kristo <t-kristo@...com>
> Signed-off-by: Suman Anna <s-anna@...com>
> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
>
> I am not sure whom to drop and whom to keep that's why I have been keeping all
> the tags that were present from the beginning.
>
> In the next version I'll keep only the SoBs tags of the the people listed above.
>
> >>
> >> You didn't add review/ack tags either.
> >
> > Those are important.
> >
> > Please send another patchset that clears checkpatch with review/acks and I'll
> > look at it.
> >
>
> I am really sorry for that, I was not aware about adding review tags as I am
> very new to upstreaming.
>

... and that is fine - we all learn as we go.  Your new patchset is at
the top of my queue and I will review it next week.

> I will share new version after fixing checkpatch errors/warnings and adding
> review tags.
>
> Thanks,
> Danish.
>
> > Thanks,
> > Mathieu
> >
> >>
> >>> ---
> >>>  .../bindings/remoteproc/ti,pru-consumer.yaml  | 60 +++++++++++++++++++
> >>>  1 file changed, 60 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml