linux-kernel - Re: [PATCH v5 6/6] zsmalloc: Implement writeback mechanism for zsmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221118220808.1194168-1-nphamcs@gmail.com>
Date:   Fri, 18 Nov 2022 14:08:08 -0800
From:   Nhat Pham <nphamcs@...il.com>
To:     minchan@...nel.org
Cc:     hannes@...xchg.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, ngupta@...are.org,
        senozhatsky@...omium.org, akpm@...ux-foundation.org,
        sjenning@...hat.com, ddstreet@...e.org, vitaly.wool@...sulko.com
Subject: Re: [PATCH v5 6/6] zsmalloc: Implement writeback mechanism for zsmalloc 

Thanks a lot for the suggestions so far and for the review, Minchan!
Quick question about your last comment:

>> +#ifdef CONFIG_ZPOOL
>
> Let's remove the ifdef machinery here.
>
>> +     /* Free all deferred handles from zs_free */
>> +     free_handles(pool, zspage);
>> +#endif

free_handles() here is for the deferred handle freeing, which is also
under CONFIG_ZPOOL now, so I don't think we should remove the #ifdef
CONFIG_ZPOOL here, no? Let me know if I'm misunderstanding your
suggestion, or if you have any further comments regarding this patch.