linux-kernel - Re: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221118225635.GA686528@roeck-us.net>
Date:   Fri, 18 Nov 2022 14:56:35 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Peter Rosin <peda@...ntia.se>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:21PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/i2c/muxes/i2c-mux-pca9541.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index ea83de78f52d..09d1d9e67e31 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -283,8 +283,7 @@ static int pca9541_release_chan(struct i2c_mux_core *muxc, u32 chan)
>  /*
>   * I2C init/probing/exit functions
>   */
> -static int pca9541_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int pca9541_probe(struct i2c_client *client)
>  {
>  	struct i2c_adapter *adap = client->adapter;
>  	struct i2c_mux_core *muxc;
> @@ -337,7 +336,7 @@ static struct i2c_driver pca9541_driver = {
>  		   .name = "pca9541",
>  		   .of_match_table = of_match_ptr(pca9541_of_match),
>  		   },
> -	.probe = pca9541_probe,
> +	.probe_new = pca9541_probe,
>  	.remove = pca9541_remove,
>  	.id_table = pca9541_id,
>  };
> -- 
> 2.38.1
>