linux-kernel - Re: [PATCH 603/606] ASoC: codecs: src4xxx-i2c: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f431abb-356c-b057-2784-6b5f165a2a2d@flatmax.com>
Date:   Sat, 19 Nov 2022 10:01:07 +1100
From:   Matt Flax <flatmax@...tmax.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 603/606] ASoC: codecs: src4xxx-i2c: Convert to i2c's
 .probe_new()

Reviewed-by: Matt Flax <flatmax@...tmax.com>

On 19/11/22 09:45, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>   sound/soc/codecs/src4xxx-i2c.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/src4xxx-i2c.c b/sound/soc/codecs/src4xxx-i2c.c
> index 43daa9dc8ab5..27026030704a 100644
> --- a/sound/soc/codecs/src4xxx-i2c.c
> +++ b/sound/soc/codecs/src4xxx-i2c.c
> @@ -12,8 +12,7 @@
>   
>   #include "src4xxx.h"
>   
> -static int src4xxx_i2c_probe(struct i2c_client *i2c,
> -			const struct i2c_device_id *id)
> +static int src4xxx_i2c_probe(struct i2c_client *i2c)
>   {
>   	return src4xxx_probe(&i2c->dev,
>   		devm_regmap_init_i2c(i2c, &src4xxx_regmap_config), NULL);
> @@ -37,7 +36,7 @@ static struct i2c_driver src4xxx_i2c_driver = {
>   		.name = "src4xxx",
>   		.of_match_table = of_match_ptr(src4xxx_of_match),
>   	},
> -	.probe = src4xxx_i2c_probe,
> +	.probe_new = src4xxx_i2c_probe,
>   	.id_table = src4xxx_i2c_ids,
>   };
>   module_i2c_driver(src4xxx_i2c_driver);