linux-kernel - Re: [PATCH 185/606] iio: temperature: mlx90614: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv63uupCo5FjXseSQzk3Ngdce8wtppBib5xxLtCypW4izi9Dw@mail.gmail.com>
Date:   Sat, 19 Nov 2022 00:03:49 +0100
From:   Crt Mori <cmo@...exis.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>, linux-i2c@...r.kernel.org,
        kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 185/606] iio: temperature: mlx90614: Convert to i2c's .probe_new()

Acked-by: Crt Mori<cmo@...exis.com>

Crt Mori

Melexis Technologies NV
Transportstraat 1
3980 Tessenderlo

Mobile: +32 492 46 22 15
E-mail: cmo@...exis.com
Website: www.melexis.com

----------------------------------------------------------
The contents of this e-mail are CONFIDENTIAL AND PROPRIETARY. Please
read our disclaimer at http://www.melexis.com/mailpolicy


On Fri, 18 Nov 2022 at 23:46, Uwe Kleine-König <uwe@...ine-koenig.org> wrote:
>
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/iio/temperature/mlx90614.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c
> index 8eb0f962ed25..909fadb62349 100644
> --- a/drivers/iio/temperature/mlx90614.c
> +++ b/drivers/iio/temperature/mlx90614.c
> @@ -537,9 +537,9 @@ static int mlx90614_probe_num_ir_sensors(struct i2c_client *client)
>         return (ret & MLX90614_CONFIG_DUAL_MASK) ? 1 : 0;
>  }
>
> -static int mlx90614_probe(struct i2c_client *client,
> -                        const struct i2c_device_id *id)
> +static int mlx90614_probe(struct i2c_client *client)
>  {
> +       const struct i2c_device_id *id = i2c_client_get_device_id(client);
>         struct iio_dev *indio_dev;
>         struct mlx90614_data *data;
>         int ret;
> @@ -675,7 +675,7 @@ static struct i2c_driver mlx90614_driver = {
>                 .of_match_table = mlx90614_of_match,
>                 .pm     = pm_ptr(&mlx90614_pm_ops),
>         },
> -       .probe = mlx90614_probe,
> +       .probe_new = mlx90614_probe,
>         .remove = mlx90614_remove,
>         .id_table = mlx90614_id,
>  };
> --
> 2.38.1
>