[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0ff119d8-958b-4978-83c7-e066b8e0cab9@ixit.cz>
Date: Sat, 19 Nov 2022 00:05:35 +0100
From: David Heidelberg <david@...t.cz>
To: Uwe Kleine-König <uwe@...ine-koenig.org>,
Angel Iglesias <ang.iglesiasg@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Grant Likely <grant.likely@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Paul Cercueil <paul@...pouillou.net>
Cc: linux-i2c@...r.kernel.org, kernel@...gutronix.de,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Lars-Peter Clausen <lars@...afoo.de>,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 114/606] iio: light: al3010: Convert to i2c's .probe_new()
Thank you!
Reviewed-by: David Heidelberg <david@...t.cz>
On 18/11/2022 23:37, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> drivers/iio/light/al3010.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
> index ce5363845b22..69cc723e2ac4 100644
> --- a/drivers/iio/light/al3010.c
> +++ b/drivers/iio/light/al3010.c
> @@ -164,8 +164,7 @@ static const struct iio_info al3010_info = {
> .attrs = &al3010_attribute_group,
> };
>
> -static int al3010_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int al3010_probe(struct i2c_client *client)
> {
> struct al3010_data *data;
> struct iio_dev *indio_dev;
> @@ -230,7 +229,7 @@ static struct i2c_driver al3010_driver = {
> .of_match_table = al3010_of_match,
> .pm = pm_sleep_ptr(&al3010_pm_ops),
> },
> - .probe = al3010_probe,
> + .probe_new = al3010_probe,
> .id_table = al3010_id,
> };
> module_i2c_driver(al3010_driver);
--
David Heidelberg
Consultant Software Engineer
Powered by blists - more mailing lists