linux-kernel - Re: [PATCH 264/606] Input: wacom_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ecb333d9-b681-4024-ac3a-3a9e51d613eb@app.fastmail.com>
Date:   Sat, 19 Nov 2022 09:27:04 +1000
From:   Alistair <alistair@...stair23.me>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        "Angel Iglesias" <ang.iglesiasg@...il.com>,
        "Lee Jones" <lee.jones@...aro.org>,
        "Grant Likely" <grant.likely@...aro.org>,
        "Wolfram Sang" <wsa@...nel.org>,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-input@...r.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 264/606] Input: wacom_i2c - Convert to i2c's .probe_new()

On Sat, 19 Nov 2022, at 8:39 AM, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Alistair Francis <alistair@...stair23.me>

> ---
> drivers/input/touchscreen/wacom_i2c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/wacom_i2c.c b/drivers/input/touchscreen/wacom_i2c.c
> index 141754b2764c..c9188ee00c62 100644
> --- a/drivers/input/touchscreen/wacom_i2c.c
> +++ b/drivers/input/touchscreen/wacom_i2c.c
> @@ -162,8 +162,7 @@ static void wacom_i2c_close(struct input_dev *dev)
> disable_irq(client->irq);
> }
>  
> -static int wacom_i2c_probe(struct i2c_client *client,
> -    const struct i2c_device_id *id)
> +static int wacom_i2c_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct wacom_i2c *wac_i2c;
> @@ -265,7 +264,7 @@ static struct i2c_driver wacom_i2c_driver = {
> .pm = &wacom_i2c_pm,
> },
>  
> - .probe = wacom_i2c_probe,
> + .probe_new = wacom_i2c_probe,
> .id_table = wacom_i2c_id,
> };
> module_i2c_driver(wacom_i2c_driver);
> -- 
> 2.38.1
> 
>