[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3cW92Hb8KpEuuQk@cmpxchg.org>
Date: Fri, 18 Nov 2022 00:24:07 -0500
From: Johannes Weiner <hannes@...xchg.org>
To: Minchan Kim <minchan@...nel.org>
Cc: Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org,
ngupta@...are.org, senozhatsky@...omium.org, sjenning@...hat.com,
ddstreet@...e.org, vitaly.wool@...sulko.com
Subject: Re: [PATCH v4 5/5] zsmalloc: Implement writeback mechanism for
zsmalloc
On Thu, Nov 17, 2022 at 02:48:28PM -0800, Minchan Kim wrote:
> On Thu, Nov 17, 2022 at 08:38:39AM -0800, Nhat Pham wrote:
> > @@ -449,6 +450,27 @@ static void zs_zpool_free(void *pool, unsigned long handle)
> > zs_free(pool, handle);
> > }
> >
> > +static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries);
> > +
> > +static int zs_zpool_shrink(void *pool, unsigned int pages,
>
> what pages?
Hm? This is the number of driver pages to clear out. The name matches
the function signature for this callback in struct zpool_driver:
int (*shrink)(void *pool, unsigned int pages,
unsigned int *reclaimed);
I agree with the rest of the feedback.
Thanks for taking a look, Minchan!
Powered by blists - more mailing lists