lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BN9PR11MB52761A0C8124248D78076B3F8C099@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Fri, 18 Nov 2022 07:50:17 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
CC:     "x86@...nel.org" <x86@...nel.org>, Joerg Roedel <joro@...tes.org>,
        "Will Deacon" <will@...nel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@....com>,
        Marc Zyngier <maz@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...lanox.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        "Raj, Ashok" <ashok.raj@...el.com>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>,
        "Ahmed S. Darwish" <darwi@...utronix.de>,
        "Chatre, Reinette" <reinette.chatre@...el.com>
Subject: RE: [patch 06/20] genirq/msi: Check for invalid MSI parent domain
 usage

> From: Thomas Gleixner <tglx@...utronix.de>
> Sent: Friday, November 11, 2022 9:57 PM
> 
> @@ -937,13 +937,21 @@ int msi_domain_alloc_irqs_descs_locked(s
> 
>  	lockdep_assert_held(&dev->msi.data->mutex);
> 
> +	if (WARN_ON_ONCE(irq_domain_is_msi_parent(domain))) {
> +		ret = -EINVAL;
> +		goto free;
> +	}
> +
> +	/* Frees allocated descriptors in case of failure. */
>  	ret = msi_domain_add_simple_msi_descs(info, dev, nvec);
>  	if (ret)
>  		return ret;

it's unusual to see a direct return when error unwind is already required
at an early failure point. is it something which can be improved here?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ