linux-kernel - RE: [patch 11/20] genirq/msi: Make descriptor allocation device domain aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2022 08:10:21 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
CC:     "x86@...nel.org" <x86@...nel.org>, Joerg Roedel <joro@...tes.org>,
        "Will Deacon" <will@...nel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@....com>,
        Marc Zyngier <maz@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...lanox.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        "Raj, Ashok" <ashok.raj@...el.com>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>,
        "Ahmed S. Darwish" <darwi@...utronix.de>,
        "Chatre, Reinette" <reinette.chatre@...el.com>
Subject: RE: [patch 11/20] genirq/msi: Make descriptor allocation device
 domain aware

> From: Thomas Gleixner <tglx@...utronix.de>
> Sent: Friday, November 11, 2022 9:57 PM
> 
> +/**
> + * msi_insert_msi_desc - Allocate and initialize a MSI descriptor in the
> default domain

and "insert it at @init_desc->msi_index", same as the text for
msi_domain_insert_msi_desc().

> @@ -183,6 +202,9 @@ void msi_free_msi_descs_range(struct dev
>  	struct msi_desc *desc;
>  	unsigned long idx;
> 
> +	if (WARN_ON_ONCE(first_index >= MSI_MAX_INDEX || last_index >=
> MSI_MAX_INDEX))
> +		return;
> +
>  	lockdep_assert_held(&dev->msi.data->mutex);
> 
>  	xa_for_each_range(xa, idx, desc, first_index, last_index) {

this doesn't belong to allocation. and next patch will convert it to
domid aware plus a formal check. Probably can just remove it
from this patch.