linux-kernel - Re: [PATCH linux-next] soc: qcom: smem_state: Use device_match_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2022 08:52:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     ye.xingchen@....com.cn, agross@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, andersson@...nel.org,
        konrad.dybcio@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] soc: qcom: smem_state: Use
 device_match_of_node()

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20221116]

url:    https://github.com/intel-lab-lkp/linux/commits/ye-xingchen-zte-com-cn/soc-qcom-smem_state-Use-device_match_of_node/20221117-154927
patch link:    https://lore.kernel.org/r/202211171548066327249%40zte.com.cn
patch subject: [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node()
config: ia64-randconfig-r001-20221117
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4591339dd50eaf6b514f1994b2cc54d7ac3c5cd2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review ye-xingchen-zte-com-cn/soc-qcom-smem_state-Use-device_match_of_node/20221117-154927
        git checkout 4591339dd50eaf6b514f1994b2cc54d7ac3c5cd2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/soc/qcom/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/soc/qcom/smem_state.c: In function 'of_node_to_state':
>> drivers/soc/qcom/smem_state.c:66:42: error: passing argument 1 of 'device_match_of_node' from incompatible pointer type [-Werror=incompatible-pointer-types]
      66 |                 if (device_match_of_node(state, np)) {
         |                                          ^~~~~
         |                                          |
         |                                          struct qcom_smem_state *
   In file included from include/linux/device.h:30,
                    from drivers/soc/qcom/smem_state.c:6:
   include/linux/device/bus.h:145:41: note: expected 'struct device *' but argument is of type 'struct qcom_smem_state *'
     145 | int device_match_of_node(struct device *dev, const void *np);
         |                          ~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors


vim +/device_match_of_node +66 drivers/soc/qcom/smem_state.c

    58	
    59	static struct qcom_smem_state *of_node_to_state(struct device_node *np)
    60	{
    61		struct qcom_smem_state *state;
    62	
    63		mutex_lock(&list_lock);
    64	
    65		list_for_each_entry(state, &smem_states, list) {
  > 66			if (device_match_of_node(state, np)) {
    67				kref_get(&state->refcount);
    68				goto unlock;
    69			}
    70		}
    71		state = ERR_PTR(-EPROBE_DEFER);
    72	
    73	unlock:
    74		mutex_unlock(&list_lock);
    75	
    76		return state;
    77	}
    78	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (145642 bytes)