linux-kernel - Re: [PATCH] macsec: Fix invalid error code set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <166876044229.7589.614742433983865@kwain.local>
Date:   Fri, 18 Nov 2022 09:34:02 +0100
From:   Antoine Tenart <atenart@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH] macsec: Fix invalid error code set

Quoting YueHaibing (2022-11-18 02:12:49)
> 'ret' is defined twice in macsec_changelink(), when it is set in macsec_is_offloaded
> case, it will be invalid before return.
> 
> Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Antoine Tenart <atenart@...nel.org>

Thanks!

> ---
>  drivers/net/macsec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
> index a7b46219bab7..d73b9d535b7a 100644
> --- a/drivers/net/macsec.c
> +++ b/drivers/net/macsec.c
> @@ -3835,7 +3835,6 @@ static int macsec_changelink(struct net_device *dev, struct nlattr *tb[],
>         if (macsec_is_offloaded(macsec)) {
>                 const struct macsec_ops *ops;
>                 struct macsec_context ctx;
> -               int ret;
>  
>                 ops = macsec_get_ops(netdev_priv(dev), &ctx);
>                 if (!ops) {
> -- 
> 2.20.1
>