linux-kernel - Re: [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3dEjfwJKWFlSFPb@atomide.com>
Date:   Fri, 18 Nov 2022 10:38:37 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc:     linux-kernel@...r.kernel.org,
        Amarula patchwork <linux-amarula@...rulasolutions.com>,
        michael@...rulasolutions.com, Allison Randal <allison@...utok.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jakob Koschel <jakobkoschel@...il.com>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Len Baker <len.baker@....com>, Liang He <windhl@....com>,
        Miaoqian Lin <linmq006@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
        Tero Kristo <kristo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-clk@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API

* Dario Binacchi <dario.binacchi@...rulasolutions.com> [221113 18:01]:
> The ti_clk_register() and ti_clk_register_omap_hw() functions are always
> called with the parameter of type "struct device" set to NULL, since the
> functions from which they are called always have a parameter of type
> "struct device_node". Replacing "struct device" type parameter with
> "struct device_node" will allow you to register a TI clock to the common
> clock framework by taking advantage of the facilities provided by the
> "struct device_node" type. Further, adding the "of_" prefix to the name
> of these functions explicitly binds them to the "struct device_node"
> type.

Looks good to me, nice clean-up:

Reviewed-by: Tony Lindgren <tony@...mide.com>
Tested-by: Tony Lindgren <tony@...mide.com>