linux-kernel - Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <594be897-f710-fb62-0882-8a7f01b21bfe@linaro.org>
Date:   Fri, 18 Nov 2022 10:16:20 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Vinod Koul <vkoul@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node



On 17/11/2022 15:57, Konrad Dybcio wrote:
> 
> 
> On 26/10/2022 07:33, Vinod Koul wrote:
>> On 24-10-22, 21:58, Dmitry Baryshkov wrote:
>>> On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski
>>> <krzysztof.kozlowski@...aro.org> wrote:
>>>>
>>>> On 24/10/2022 12:48, Dmitry Baryshkov wrote:
>>>>> On 24/10/2022 19:46, Krzysztof Kozlowski wrote:
>>>>>> On 24/10/2022 12:45, Dmitry Baryshkov wrote:
>>>>>>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote:
>>>>>>>> On 09/12/2021 05:35, Vinod Koul wrote:
>>>>>>>>> Add the spmi bus as found in the SM8450 SoC
>>>>>>>>>
>>>>>>>>> Signed-off-by: Vinod Koul <vkoul@...nel.org>
>>>>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
>>>>>>>>> ---
>>>>>>>>>     arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++
>>>>>>>>>     1 file changed, 18 insertions(+)
>>>>>>>>>
>>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi 
>>>>>>>>> b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>>>>>> index f75de777f6ea..b80e34fd3fe1 100644
>>>>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>>>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@...0000 {
>>>>>>>>>                            interrupt-controller;
>>>>>>>>>                    };
>>>>>>>>>
>>>>>>>>> +         spmi_bus: spmi@...d000 {
>>>>>>>>> +                 compatible = "qcom,spmi-pmic-arb";
>>>>>>>>> +                 reg = <0x0 0x0c400000 0x0 0x00003000>,
>>>>>>>>> +                       <0x0 0x0c500000 0x0 0x00400000>,
>>>>>>>>> +                       <0x0 0x0c440000 0x0 0x00080000>,
>>>>>>>>> +                       <0x0 0x0c4c0000 0x0 0x00010000>,
>>>>>>>>> +                       <0x0 0x0c42d000 0x0 0x00010000>;
>>>>>>>>
>>>>>>>> This is a patch from December 2021. Is there anything blocking 
>>>>>>>> it from
>>>>>>>> being merged?
>>>>>>>>
>>>>>>>> The same applies to several other patches here.
>>>>>>>
>>>>>>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb 
>>>>>>> support
>>>>>>> for the PMIC on the SM8450 platform. Thus we also can not merge 
>>>>>>> the DT
>>>>>>> parts.
>>>>>>
>>>>>> Why we cannot merge DTS? How is DTS with new nodes depending on any
>>>>>> driver changes?
>>>>>
>>>>> In this particular case, there was an open question, what should be 
>>>>> the
>>>>> bindings for the PMIC ARB v7.
>>>>
>>>> Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait
>>>> with this one. I just had an impression that it's about driver 
>>>> changes...
>>>
>>> Yes, it's about binding. Thus we have been waiting for quite some time.
>>
>> Yes sadly Steven has stopped responding to emails or IRC.. I am not
>> sure whats going on!
>>
>> Even the SPMI tree is not being actively maintained with only few
>> patches which were picked in last cycle since this year!
> It's in -next now and 8450 boots and works fine. If the binding 
> situation has been resolved, I say merge this ASAP! :)
> 
> Konrad
With a small nit: it needs to be rebased, and should come between 
aoss_qmp: and ipcc: address-wise (ipcc wasn't around a year ago in this 
DT, it seems). Also most (all?) other nodes in the DT use reg = <0 [..]> 
instead of reg = <0x0 [..]> so that could be fixed up as well.

Konrad
>>