linux-kernel - Re: [PATCH 1/1] mmc: sdhci: Fixed too many logs being printed during tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Da2qxX2kPX8ArHnh=xk=M3qE7fBD=3D+pV3VkT-S2_1kCzXA@mail.gmail.com>
Date:   Fri, 18 Nov 2022 17:22:01 +0800
From:   Wenchao Chen <wenchao.chen666@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     adrian.hunter@...el.com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, megoo.tang@...il.com,
        lzx.stg@...il.com
Subject: Re: [PATCH 1/1] mmc: sdhci: Fixed too many logs being printed during tuning

On Wed, Nov 16, 2022 at 11:21 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Fri, 11 Nov 2022 at 09:42, Wenchao Chen <wenchao.chen666@...il.com> wrote:
> >
> > From: Wenchao Chen <wenchao.chen@...soc.com>
> >
> > During the HS200 tuning process, too many tuning errors are printed in
> > the log.
> >
> > Signed-off-by: Wenchao Chen <wenchao.chen@...soc.com>
> > ---
> >  drivers/mmc/host/sdhci.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > index fef03de85b99..a503b54305eb 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -3401,6 +3401,10 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
> >                 if (host->pending_reset)
> >                         return;
> >
> > +               command = SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND));
> > +               if (command == MMC_SEND_TUNING_BLOCK || command == MMC_SEND_TUNING_BLOCK_HS200)
> > +                       return;
> > +
>
> Please use mmc_op_tuning() instead of open-coding this. I also need an
> ack from Adrian to apply this.

Thank you for your review, I will update the next version.

>
> >                 pr_err("%s: Got data interrupt 0x%08x even though no data operation was in progress.\n",
> >                        mmc_hostname(host->mmc), (unsigned)intmask);
> >                 sdhci_err_stats_inc(host, UNEXPECTED_IRQ);
> > --
> > 2.17.1
> >
>
> Kind regards
> Uffe