linux-kernel - Re: [PATCH net-next] net: ethernet: renesas: rswitch: Fix signedness bug in rswitch_etha_wait_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXbpi_1fw-vUnuFBGS91iq4P1EB2mLg_2UMDJnNRYCr7Q@mail.gmail.com>
Date:   Fri, 18 Nov 2022 11:01:01 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     s.shtylyov@....ru, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        yoshihiro.shimoda.uh@...esas.com, andrew@...n.ch,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: renesas: rswitch: Fix signedness
 bug in rswitch_etha_wait_link_verification()

Hi Yue,

On Fri, Nov 18, 2022 at 7:36 AM YueHaibing <yuehaibing@...wei.com> wrote:
> rswitch_reg_wait() may return negative value, which converts to true later.
> However rswitch_etha_hw_init() only check it less than zero.
>
> Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks for your patch!

A similar patch was already applied as
https://git.kernel.org/netdev/net-next/c/b4b221bd79a1

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds