linux-kernel - Re: [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3deaZ+QxLqtj1Pp@krava>
Date:   Fri, 18 Nov 2022 11:28:57 +0100
From:   Jiri Olsa <olsajiri@...il.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep"

On Fri, Nov 18, 2022 at 05:50:01PM +0800, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
> 
>   sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`
> 
> Here are the steps to install the latest grep:
> 
>   wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
>   tar xf grep-3.8.tar.gz
>   cd grep-3.8 && ./configure && make
>   sudo make install
>   export PATH=/usr/local/bin:$PATH
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Acked-by: Jiri Olsa <jolsa@...nel.org>

jirka

> ---
>  samples/bpf/test_cgrp2_tc.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/bpf/test_cgrp2_tc.sh b/samples/bpf/test_cgrp2_tc.sh
> index 12faf58..395573b 100755
> --- a/samples/bpf/test_cgrp2_tc.sh
> +++ b/samples/bpf/test_cgrp2_tc.sh
> @@ -115,7 +115,7 @@ do_exit() {
>      if [ "$DEBUG" == "yes" ] && [ "$MODE" != 'cleanuponly' ]
>      then
>  	echo "------ DEBUG ------"
> -	echo "mount: "; mount | egrep '(cgroup2|bpf)'; echo
> +	echo "mount: "; mount | grep -E '(cgroup2|bpf)'; echo
>  	echo "$CGRP2_TC_LEAF: "; ls -l $CGRP2_TC_LEAF; echo
>  	if [ -d "$BPF_FS_TC_SHARE" ]
>  	then
> -- 
> 2.1.0
>