lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3eWfOUdcElS9cun@google.com>
Date:   Fri, 18 Nov 2022 14:28:12 +0000
From:   Lee Jones <lee@...nel.org>
To:     Guenter Roeck <groeck@...gle.com>
Cc:     Mark Hasemeyer <markhas@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Raul Rangel <rrangel@...omium.org>,
        Bhanu Prakash Maiya <bhanumaiya@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string
 "google,cros_ec_uart"

On Fri, 18 Nov 2022, Guenter Roeck wrote:

> On Thu, Nov 17, 2022 at 10:49 AM Mark Hasemeyer <markhas@...omium.org> wrote:
> >
> > Add DT compatible string in
> > Documentation/devicetree/bindings/mfd/cros_ec.txt
> >
> 
> This is now google,cros-ec.yaml

Also there is no need to repeat the filename in the commit message.

We can see that in the diff-stat below.

Please come up with a more imaginative commit message.

Exactly what are you doing, why you're doing it will do.

> > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
> > Signed-off-by: Mark Hasemeyer <markhas@...omium.org>
> > ---
> >
> > Changes in v7:
> > - No change
> >
> > Changes in v6:
> > - No change
> >
> > Changes in v5:
> > - No change
> >
> > Changes in v4:
> > - Changes in commit message.
> >
> > Changes in v3:
> > - Rebased changes on google,cros-ec.yaml
> >
> > Changes in v2:
> > - No change
> >
> > ---
> >  .../devicetree/bindings/mfd/google,cros-ec.yaml       | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > index 04962bb29576e..26787e4574b8d 100644
> > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > @@ -28,6 +28,9 @@ properties:
> >        - description:
> >            For implementations of the EC is connected through RPMSG.
> >          const: google,cros-ec-rpmsg
> > +      - description:
> > +          For implementations of the EC is connected through UART.
> > +        const: google,cros-ec-uart
> >
> >    controller-data:
> >      description:
> > @@ -222,4 +225,12 @@ examples:
> >              compatible = "google,cros-ec-rpmsg";
> >          };
> >      };
> > +
> > +  # Example for UART
> > +  - |
> > +    uart0 {
> > +        cros-ec {
> > +            compatible = "google,cros-ec-uart";
> > +        };
> > +    };
> >  ...
> >

-- 
Lee Jones [李琼斯]

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ