[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <86d3cb18-4e31-7389-f982-7985cf976791@linaro.org>
Date: Fri, 18 Nov 2022 15:55:25 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Neil Armstrong <neil.armstrong@...aro.org>,
Jakub Kicinski <kuba@...nel.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Rob Herring <robh+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Alessandro Zummo <a.zummo@...ertech.it>,
Eric Dumazet <edumazet@...gle.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Kevin Hilman <khilman@...libre.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Heiner Kallweit <hkallweit1@...il.com>,
Vinod Koul <vkoul@...nel.org>,
Russell King <linux@...linux.org.uk>,
Thomas Gleixner <tglx@...utronix.de>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Jerome Brunet <jbrunet@...libre.com>,
Paolo Abeni <pabeni@...hat.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
"David S. Miller" <davem@...emloft.net>
Cc: linux-media@...r.kernel.org, netdev@...r.kernel.org,
linux-amlogic@...ts.infradead.org, linux-mmc@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-pci@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 09/12] dt-bindings: phy: convert meson-gxl-usb2-phy.txt to
dt-schema
On 18/11/2022 15:33, Neil Armstrong wrote:
> Convert the Amlogic Meson GXL USB2 PHY bindings to dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
> .../bindings/phy/amlogic,meson-gxl-usb2-phy.yaml | 56 ++++++++++++++++++++++
> .../devicetree/bindings/phy/meson-gxl-usb2-phy.txt | 21 --------
> 2 files changed, 56 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-gxl-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-gxl-usb2-phy.yaml
> new file mode 100644
> index 000000000000..4dd287f1f400
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-gxl-usb2-phy.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/amlogic,meson-gxl-usb2-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic Meson GXL USB2 PHY
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@...aro.org>
> +
> +properties:
> + compatible:
> + const: amlogic,meson-gxl-usb2-phy
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: phy
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + items:
> + - const: phy
> +
> + "#phy-cells":
> + const: 0
> +
> + phy-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + phy@...00 {
> + compatible = "amlogic,meson-gxl-usb2-phy";
> + reg = <0x78000 0x20>;
> + clocks = <&xtal>;
> + clock-names = "phy";
> + resets = <&phy_reset>;
> + reset-names = "phy";
> + #phy-cells = <0>;
> + phy-supply = <&usb2_supply>;
Use 4 spaces for example indentation.
With indentation fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists