linux-kernel - Re: [PATCH 289/606] macintosh: ams/ams-i2c: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221119101602.kfreiw4mdbjf7prj@pengutronix.de>
Date:   Sat, 19 Nov 2022 11:16:02 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Minghao Chi <chi.minghao@....com.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH 289/606] macintosh: ams/ams-i2c: Convert to i2c's
 .probe_new()

Hello Christophe,

On Sat, Nov 19, 2022 at 07:38:58AM +0000, Christophe Leroy wrote:
> Le 18/11/2022 à 23:40, Uwe Kleine-König a écrit :
> > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > The probe function doesn't make use of the i2c_device_id * parameter so it
> > can be trivially converted.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The patch itself and the others seems ok. But can you group all 
> macintosh changes into a single patch instead of the 9 patches you sent ?
> 
> See the process about submitting patches, 
> https://docs.kernel.org/process/submitting-patches.html and especially 
> the "NO!!!! No more huge patch bombs to linux-kernel@...r.kernel.org 
> people!" and the associated reference 
> https://lore.kernel.org/all/20050711.125305.08322243.davem@davemloft.net/ :
> 
> 	If you feel the need to send, say, more than 15 patches at once, 
> reconsider.

Thanks for your feedback.

Let me point out in response to the request to squash patches together
that this wish doesn't seem to be the universal right thing to do.

Last time I did a conversion grouped by subsystem, one of the replies
was:

	Reviewed-by: ...
	if you split on per driver basis.

(https://lore.kernel.org/linux-iio/20220808085526.280066-1-u.kleine-koenig@pengutronix.de)

The obvious upside of a split per driver is that the individual bits are
easier to review, an Ack can be limited to a certain set of drivers, and
(probably most important): If a driver later gets a commit that needs
backporting, a patch that only touches this single driver can more
easily be backported as a dependency.

Also the request to not send everything at once but keep back some
patches has an obvious downside. I.e. I have to restart yet more often
to rebase + test to get all patches applied in the end. And you could
argue that the sum of the work load on the mail servers doesn't get
smaller in sum if the 600 patches are sent over (say) 2 months.
(To prevent a flame war here: Yeah, I agree there are downsides of a
single big series, too.)

All in all my personal opinion is that the advantages of a split per
driver slightly outweight the disadvantages. But obviously that's
subjective.

I will wait a while before sending updates to this series, so don't
expect a new patch very soon. (This has the nice effect that it gives
you some time to reconsider your argument and maybe apply the patches as
they are now, preventing another mail to the lists with the cumulated
macintosh changes ;-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)