linux-kernel - Re: [PATCH 028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3kTnO5C/ilRa1uw@pendragon.ideasonboard.com>
Date:   Sat, 19 Nov 2022 19:34:20 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <robert.foss@...aro.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, linux-i2c@...r.kernel.org,
        kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 028/606] drm/bridge: parade-ps8622: Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:36:02PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/parade-ps8622.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 309de802863d..530ee6a19e7e 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -442,9 +442,9 @@ static const struct of_device_id ps8622_devices[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ps8622_devices);
>  
> -static int ps8622_probe(struct i2c_client *client,
> -					const struct i2c_device_id *id)
> +static int ps8622_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct device *dev = &client->dev;
>  	struct ps8622_bridge *ps8622;
>  	struct drm_bridge *panel_bridge;
> @@ -538,7 +538,7 @@ MODULE_DEVICE_TABLE(i2c, ps8622_i2c_table);
>  
>  static struct i2c_driver ps8622_driver = {
>  	.id_table	= ps8622_i2c_table,
> -	.probe		= ps8622_probe,
> +	.probe_new	= ps8622_probe,
>  	.remove		= ps8622_remove,
>  	.driver		= {
>  		.name	= "ps8622",
> -- 
> 2.38.1
> 

-- 
Regards,

Laurent Pinchart