linux-kernel - Re: [PATCH] ubifs: Fix build errors as symbol undefined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <433070166.256175.1668893150374.JavaMail.zimbra@nod.at>
Date:   Sat, 19 Nov 2022 22:25:50 +0100 (CET)
From:   Richard Weinberger <richard@....at>
To:     "Lihua (lihua, ran)" <hucool.lihua@...wei.com>
Cc:     Sascha Hauer <s.hauer@...gutronix.de>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>, yusongping@...wei.com
Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined

----- Ursprüngliche Mail -----
> Von: "Lihua (lihua, ran)" <hucool.lihua@...wei.com>
>> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
>> index 45d3d207fb99..93bda1057fdc 100644
>> --- a/fs/ubifs/Kconfig
>> +++ b/fs/ubifs/Kconfig
>> @@ -13,6 +13,7 @@ config UBIFS_FS
>>   	select CRYPTO_HASH_INFO
>>   	select UBIFS_FS_XATTR if FS_ENCRYPTION
>>   	select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
>> +	select UBIFS_FS_AUTHENTICATION

I fear this is not a proper fix.
This changes does not longer allow building UBIFS without the authentication feature.
With what configuration do you see this error?

I just tried with:
CONFIG_UBIFS_FS=m
CONFIG_UBIFS_FS_ADVANCED_COMPR=y
CONFIG_UBIFS_FS_LZO=y
CONFIG_UBIFS_FS_ZLIB=y
CONFIG_UBIFS_FS_ZSTD=y
CONFIG_UBIFS_ATIME_SUPPORT=y
CONFIG_UBIFS_FS_XATTR=y
CONFIG_UBIFS_FS_SECURITY=y
# CONFIG_UBIFS_FS_AUTHENTICATION is not set

But don't get the error and, as expected, fs/ubifs/ubifs.o has no
reference to ubifs_bad_hash.

Thanks,
//richard