linux-kernel - Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb94bd7d-0b65-a832-48e9-b1518719db51@gmail.com>
Date:   Sun, 20 Nov 2022 20:57:44 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        cw00.choi@...sung.com, krzysztof.kozlowski@...aro.org,
        myungjoo.ham@...sung.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with
 unmask_base

On 22. 11. 13. 00:24, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> ---
>  drivers/extcon/extcon-max77843.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 8e6e97ec65a8..1bc0426ce3f1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -189,8 +189,7 @@ static const struct regmap_irq max77843_muic_irq[] = {
>  static const struct regmap_irq_chip max77843_muic_irq_chip = {
>  	.name           = "max77843-muic",
>  	.status_base    = MAX77843_MUIC_REG_INT1,
> -	.mask_base      = MAX77843_MUIC_REG_INTMASK1,
> -	.mask_invert    = true,
> +	.unmask_base    = MAX77843_MUIC_REG_INTMASK1,
>  	.num_regs       = 3,
>  	.irqs           = max77843_muic_irq,
>  	.num_irqs       = ARRAY_SIZE(max77843_muic_irq),

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi