linux-kernel - Re: [PATCH v2] hwmon: (asus-ec-sensors) add definitions for ROG ZENITH II EXTREME ALPHA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221120140057.GA1788720@roeck-us.net>
Date:   Sun, 20 Nov 2022 06:00:57 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Matthew Dawson <matthew@...systems.ca>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>,
        Eugene Shalygin <eugene.shalygin@...il.com>
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add definitions for ROG
 ZENITH II EXTREME ALPHA

On Fri, Nov 18, 2022 at 10:36:22AM -0500, Matthew Dawson wrote:
> Add support for the Zenith II Extreme Alpha.  It is basically the same
> board as the Zenith II Extreme, and has a similar sensor suite.  The
> DSDT is basically the same except for some address, so use the same
> board information as the non-Alpha board.
> 
> Cc: stable@...r.kernel.org
> 
> Signed-off-by: Matthew Dawson <matthew@...systems.ca>
> ---
> v2: Add missing Documentation change
> 
>  Documentation/hwmon/asus_ec_sensors.rst | 1 +
>  drivers/hwmon/asus-ec-sensors.c         | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/
> asus_ec_sensors.rst

Your patch is corrupted. The line above is split. If I try to fix that, I get

error: patch failed: drivers/hwmon/asus-ec-sensors.c:466
error: drivers/hwmon/asus-ec-sensors.c: patch does not apply
error: Did you hand edit your patch?

It looks like tabs were raplaced with spaces. Please fix and resubmit.

Thanks,
Guenter

> index 02f4ad314a1e..a4039f2f9ca4 100644
> --- a/Documentation/hwmon/asus_ec_sensors.rst
> +++ b/Documentation/hwmon/asus_ec_sensors.rst
> @@ -23,6 +23,7 @@ Supported boards:
>   * ROG STRIX X570-I GAMING
>   * ROG STRIX Z690-A GAMING WIFI D4
>   * ROG ZENITH II EXTREME
> + * ROG ZENITH II EXTREME ALPHA
>  
>  Authors:
>      - Eugene Shalygin <eugene.shalygin@...il.com>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 81e688975c6a..ac0459be04c7 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -466,6 +466,8 @@ static const struct dmi_system_id dmi_table[] = {
>                                         &board_info_strix_z690_a_gaming_wifi_d4),
>         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME",
>                                         &board_info_zenith_ii_extreme),
> +       DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
> +                                       &board_info_zenith_ii_extreme),
>         {},
>  };
>