| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221120153049.GA3081277-robh@kernel.org>
Date: Sun, 20 Nov 2022 09:30:49 -0600
From: Rob Herring <robh@...nel.org>
To: Ash Logan <ash@...quark.com>
Cc: krzysztof.kozlowski+dt@...aro.org, paulus@...ba.org,
mpe@...erman.id.au, christophe.leroy@...roup.eu,
benh@...nel.crashing.org, segher@...nel.crashing.org,
pali@...nel.org, linux-kernel@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, j.ne@...teo.net,
linkmauve@...kmauve.fr, rw-r-r-0644@...tonmail.com,
devicetree@...r.kernel.org, joel@....id.au
Subject: Re: [PATCH v4 01/11] dt-bindings: wiiu: Document the Nintendo Wii U
devicetree
On Sat, Nov 19, 2022 at 10:30:31PM +1100, Ash Logan wrote:
> Adds schema for the various Wii U devicetree nodes used.
>
> Signed-off-by: Ash Logan <ash@...quark.com>
> ---
> v3->v4: Rework to match expected style and conciceness.
>
> .../bindings/powerpc/nintendo/wiiu.yaml | 25 +++++++++
> .../powerpc/nintendo/wiiu/espresso-pic.yaml | 48 ++++++++++++++++
> .../bindings/powerpc/nintendo/wiiu/gpu7.yaml | 42 ++++++++++++++
> .../powerpc/nintendo/wiiu/latte-ahci.yaml | 50 +++++++++++++++++
> .../powerpc/nintendo/wiiu/latte-dsp.yaml | 35 ++++++++++++
> .../powerpc/nintendo/wiiu/latte-pic.yaml | 55 +++++++++++++++++++
> .../powerpc/nintendo/wiiu/latte-sdhci.yaml | 46 ++++++++++++++++
> .../bindings/powerpc/nintendo/wiiu/latte.yaml | 31 +++++++++++
> .../devicetree/bindings/usb/generic-ehci.yaml | 1 +
> 9 files changed, 333 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/espresso-pic.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/gpu7.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-ahci.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-dsp.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-pic.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-sdhci.yaml
> create mode 100644 Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte.yaml
>
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu.yaml
> new file mode 100644
> index 000000000000..23703b1052d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu.yaml
> @@ -0,0 +1,25 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U bindings
Everything is a binding, so drop 'bindings'.
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
Don't need '|' if no formatting.
> + Nintendo Wii U video game console binding.
> +
> +properties:
> + $nodename:
> + const: "/"
> +
> + compatible:
> + const: nintendo,wiiu
> +
> +additionalProperties: true
> +
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/espresso-pic.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/espresso-pic.yaml
> new file mode 100644
> index 000000000000..476a8ccda7a1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/espresso-pic.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/espresso-pic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U "Espresso" interrupt controller
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + Interrupt controller found on the Nintendo Wii U for the "Espresso" processor.
> +
> +allOf:
> + - $ref: "/schemas/interrupt-controller.yaml#"
Drop quotes.
> +
> +properties:
> + compatible:
> + const: nintendo,espresso-pic
> +
> + '#interrupt-cells':
> + # Interrupt numbers 0-32 in one cell
> + const: 1
> +
> + interrupt-controller: true
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - '#interrupt-cells'
> + - interrupt-controller
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + interrupt-controller@...0078 {
> + compatible = "nintendo,espresso-pic";
> + reg = <0x0c000078 0x18>;
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/gpu7.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/gpu7.yaml
> new file mode 100644
> index 000000000000..d44ebe0d866c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/gpu7.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/gpu7.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U Latte "GPU7" graphics processor
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + GPU7 graphics processor, also known as "GX2", found in the Latte multifunction chip of the
Wrap lines at 80 unless some advantage to 100.
> + Nintendo Wii U.
> +
> +properties:
> + compatible:
> + const: nintendo,latte-gpu7
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpu@...0000 {
> + compatible = "nintendo,latte-gpu7";
> + reg = <0x0c200000 0x80000>;
> + interrupts = <2>;
> + interrupt-parent = <&espresso_pic>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-ahci.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-ahci.yaml
> new file mode 100644
> index 000000000000..a53971a11e89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-ahci.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/latte-ahci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U Latte AHCI controller
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + Nintendo Wii U AHCI SATA controller, as found in the Latte chip.
> +
> +allOf:
> + - $ref: "/schemas/ata/ahci-common.yaml#"
> +
> +properties:
> + compatible:
> + const: nintendo,latte-ahci
> +
> + reg:
> + items:
> + - description: |
> + HBA memory registers. Note that unlike the spec, space for only 6 ports exist, with 2 vendor
> + registers afterwards, thus register space should be 0x408 long (0x100+0x80*6+0x8).
> +
> + interrupts:
> + items:
> + - description: Main HBA interrupt
> + - description: Vendor debugging interrupt
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sata@...0400 {
> + compatible = "nintendo,latte-ahci";
> + reg = <0x0d160400 0x408>;
> +
> + interrupt-parent = <&latte_pic>;
> + interrupts = <38>, <28>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-dsp.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-dsp.yaml
> new file mode 100644
> index 000000000000..772afe0c298c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-dsp.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/latte-dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U Latte DSP
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + Nintendo Wii U digital signal processor, as found in the Latte chip.
> +
> +properties:
> + compatible:
> + const: nintendo,latte-dsp
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dsp@...5000 {
> + compatible = "nintendo,latte-dsp";
> + reg = <0x0c005000 0x200>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-pic.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-pic.yaml
> new file mode 100644
> index 000000000000..4b71d6b9b14d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-pic.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/latte-pic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U Latte interrupt controller
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + Interrupt controller found on the Nintendo Wii U for the "Latte" devices.
> +
> +allOf:
> + - $ref: "/schemas/interrupt-controller.yaml#"
> +
> +properties:
> + compatible:
> + const: nintendo,latte-pic
> +
> + '#interrupt-cells':
> + # Interrupt numbers 0-64 in one cell.
> + const: 1
> +
> + interrupt-controller: true
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Cascade interrupt for Espresso PIC
> +
> +required:
> + - compatible
> + - '#interrupt-cells'
> + - interrupt-controller
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + interrupt-controller@...0440 {
> + compatible = "nintendo,latte-pic";
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + reg = <0x0d800440 0x30>;
> +
> + interrupt-parent = <&espresso_pic>;
> + interrupts = <24>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-sdhci.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-sdhci.yaml
> new file mode 100644
> index 000000000000..25d474fca679
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte-sdhci.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/latte-sdhci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nintendo Wii U Latte SD Host controller
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + SDHCI hosts found on the Nintendo Wii U's Latte SoC for SD cards and SDIO devices.
> +
> +allOf:
> + - $ref: "/schemas/mmc/mmc-controller.yaml#"
> +
> +properties:
> + compatible:
> + items:
> + - const: nintendo,latte-sdhci
> + - const: sdhci
Just 'sdhci' is not too useful. *All* SDHCI controllers have quirks.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mmc@...0000 {
> + compatible = "nintendo,latte-sdhci", "sdhci";
> + reg = <0x0d070000 0x200>;
> + interrupts = <7>;
> + interrupt-parent = <&latte_pic>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte.yaml b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte.yaml
> new file mode 100644
> index 000000000000..6fdf93622fcc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wiiu/latte.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/powerpc/nintendo/wiiu/latte.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Latte system bus
> +
> +maintainers:
> + - Ash Logan <ash@...quark.com>
> + - Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> +
> +description: |
> + Latte multi-function SoC, containing many of the devices found on the Nintendo Wii U.
> +
> +allOf:
> + - $ref: "/schemas/simple-bus.yaml#"
> +
> +properties:
> + compatible:
> + items:
> + - const: nintendo,latte
> + - const: simple-bus
If truly 'simple', then you don't need 'nintendo,latte'.
Otherwise, you need a custom 'select' schema to not select all cases of
'simple-bus'.
> +
> +
one blank line
> +required:
> + - compatible
> +
> +additionalProperties: true
> +
> +...
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index c5f629c5bc61..9f69b5ab21ff 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -69,6 +69,7 @@ properties:
> - ibm,usb-ehci-440epx
> - ibm,usb-ehci-460ex
> - nintendo,hollywood-usb-ehci
> + - nintendo,latte-ehci
> - st,spear600-ehci
> - const: usb-ehci
> - enum:
> --
> 2.38.1
>
>
Powered by blists - more mailing lists