linux-kernel - Re: [PATCH 561/606] rtc: isl1208: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 20 Nov 2022 21:30:23 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-rtc@...r.kernel.org, Alessandro Zummo <a.zummo@...ertech.it>,
        linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...nel.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Grant Likely <grant.likely@...aro.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 561/606] rtc: isl1208: Convert to i2c's .probe_new()

Hello Alexandre,

On Sun, Nov 20, 2022 at 12:58:44AM +0100, Alexandre Belloni wrote:
> On 18/11/2022 23:44:55+0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > .probe_new() doesn't get the i2c_device_id * parameter, so determine
> > that explicitly in the probe function.
> > 
> 
> This is already done later on in the function, please check the rtc
> patches as I took your previous series.

huh, sorry I missed that. In this previous series you refused to take
the ds1307 patch. The one from this series is better.

I dropped the other rtc patches from my queue.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)