[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ce1bf9f-a481-92e3-c7cc-a1b41270468d@quicinc.com>
Date: Sun, 20 Nov 2022 14:47:14 -0700
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Oded Gabbay <ogabbay@...nel.org>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Arnd Bergmann <arnd@...db.de>, <linux-kernel@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>,
Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>,
Jiho Chu <jiho.chu@...sung.com>,
Daniel Stone <daniel@...ishbar.org>,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
Jason Gunthorpe <jgg@...dia.com>,
Christoph Hellwig <hch@...radead.org>,
Kevin Hilman <khilman@...libre.com>,
Jagan Teki <jagan@...rulasolutions.com>,
John Hubbard <jhubbard@...dia.com>,
Alex Deucher <alexander.deucher@....com>,
Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
Maciej Kwapulinski <maciej.kwapulinski@...ux.intel.com>,
Christopher Friedt <chrisfriedt@...il.com>
Subject: Re: [PATCH v4 2/4] accel: add dedicated minor for accelerator devices
On 11/19/2022 1:44 PM, Oded Gabbay wrote:
> diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
> index fac6ad6ac28e..703d40c4ff45 100644
> --- a/drivers/accel/drm_accel.c
> +++ b/drivers/accel/drm_accel.c
> @@ -8,14 +8,25 @@
>
> #include <linux/debugfs.h>
> #include <linux/device.h>
> +#include <linux/xarray.h>
Including xarray, but using idr
This should be linux/idr.h
This seems so minor, I don't think I advise spinning a v5 for it. If a
v5 is warranted elsewhere, obviously fix this. If not, hopefully this
can be fixed up by whoever applies it, or someone submits a follow up patch.
Hopefully this is the only nit. I would like to see this merged.
-Jeff
Powered by blists - more mailing lists