lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202211191625.81b30982-oliver.sang@intel.com>
Date:   Sun, 20 Nov 2022 15:39:25 +0800
From:   kernel test robot <oliver.sang@...el.com>
To:     Gao Xiang <hsiangkao@...ux.alibaba.com>
CC:     <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
        Zirong Lang <zlang@...hat.com>, <linux-xfs@...r.kernel.org>,
        "Darrick J. Wong" <djwong@...nel.org>,
        "Dave Chinner" <dchinner@...hat.com>,
        Brian Foster <bfoster@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Gao Xiang <hsiangkao@...ux.alibaba.com>
Subject: Re: [PATCH v2] xfs: extend the freelist before available space check


please be noted we noticed there are some discussion around this v2 patch,
Dave also gave some comments. it seems us there will be further refines.
we still sent out this report FYI the possible impact of this patch.

Greeting,

FYI, we noticed xfstests.xfs.076.fail due to commit (built with gcc-11):

commit: bdd2815e0ab101910e39dfcdc9a2a88e01a3d39b ("[PATCH v2] xfs: extend the freelist before available space check")
url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20221103-211312/Gao-Xiang/xfs-extend-the-freelist-before-available-space-check/20221103-174840
base: https://git.kernel.org/cgit/fs/xfs/xfs-linux.git for-next
patch link: https://lore.kernel.org/all/20221103131025.40064-1-hsiangkao@linux.alibaba.com/
patch subject: [PATCH v2] xfs: extend the freelist before available space check

in testcase: xfstests
version: xfstests-x86_64-5a5e419-1_20221108
with following parameters:

	disk: 4HDD
	fs: xfs
	test: xfs-group-07

test-description: xfstests is a regression test suite for xfs and other files ystems.
test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git


on test machine: 4 threads 1 sockets Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz (Ivy Bridge) with 8G memory

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):




If you fix the issue, kindly add following tag
| Reported-by: kernel test robot <oliver.sang@...el.com>
| Link: https://lore.kernel.org/oe-lkp/202211191625.81b30982-oliver.sang@intel.com


user  :warn  : [  118.806130] run fstests xfs/076 at 2022-11-17 02:44:36
kern  :notice: [  119.589950] XFS (sda2): Mounting V5 Filesystem
kern  :info  : [  119.657030] XFS (sda2): Ending clean mount
kern  :warn  : [  119.663880] xfs filesystem being mounted at /fs/sda2 supports timestamps until 2038 (0x7fffffff)
kern  :notice: [  121.762735] XFS (sda5): Mounting V5 Filesystem
kern  :info  : [  121.975291] XFS (sda5): Ending clean mount
kern  :warn  : [  121.981897] xfs filesystem being mounted at /fs/scratch supports timestamps until 2038 (0x7fffffff)
kern  :notice: [  122.001845] XFS (sda5): Unmounting Filesystem
kern  :notice: [  122.315727] XFS (sda5): Mounting V5 Filesystem
kern  :info  : [  122.371799] XFS (sda5): Ending clean mount
kern  :warn  : [  122.378570] xfs filesystem being mounted at /fs/scratch supports timestamps until 2038 (0x7fffffff)
user  :notice: [  133.550084] xfs/076       IPMI BMC is not supported on this machine, skip bmc-watchdog setup!

kern  :alert : [  243.286999] XFS (sda5): Internal error xfs_trans_cancel at line 1097 of file fs/xfs/xfs_trans.c.  Caller xfs_create+0x9e8/0xe80 [xfs]
kern  :warn  : [  243.300093] CPU: 1 PID: 36204 Comm: touch Not tainted 6.1.0-rc1-00031-gbdd2815e0ab1 #1
kern  :warn  : [  243.308725] Hardware name: Hewlett-Packard HP Pro 3340 MT/17A1, BIOS 8.07 01/24/2013
kern  :warn  : [  243.317169] Call Trace:
kern  :warn  : [  243.320320]  <TASK>
kern  :warn  : [  243.323131]  dump_stack_lvl+0x34/0x44
kern  :warn  : [  243.327505]  xfs_trans_cancel+0x236/0x580 [xfs]
kern  :warn  : [  243.332889]  xfs_create+0x9e8/0xe80 [xfs]
kern  :warn  : [  243.337742]  ? xfs_irele+0xe0/0xe0 [xfs]
kern  :warn  : [  243.342511]  ? __wake_up_common_lock+0xe3/0x140
kern  :warn  : [  243.347751]  ? get_cached_acl_rcu+0xf0/0xf0
kern  :warn  : [  243.352647]  ? _raw_spin_lock+0x81/0xd0
kern  :warn  : [  243.357192]  xfs_generic_create+0x477/0x610 [xfs]
kern  :warn  : [  243.362737]  ? xfs_setup_iops+0x3b0/0x3b0 [xfs]
kern  :warn  : [  243.368100]  ? d_splice_alias+0xfa/0x4f0
kern  :warn  : [  243.372727]  ? arch_stack_walk+0x61/0xf0
kern  :warn  : [  243.377355]  ? xfs_vn_link+0x1c0/0x1c0 [xfs]
kern  :warn  : [  243.382461]  ? xfs_vn_lookup+0x143/0x170 [xfs]
kern  :warn  : [  243.387739]  ? inode_permission+0x91/0x500
kern  :warn  : [  243.392548]  ? xfs_vn_link+0x1c0/0x1c0 [xfs]
kern  :warn  : [  243.397646]  lookup_open+0xb47/0x1300
kern  :warn  : [  243.402630]  ? path_lookupat+0x650/0x650
kern  :warn  : [  243.407266]  ? down_write_killable+0x160/0x160
kern  :warn  : [  243.412419]  ? __legitimize_path+0x6b/0x160
kern  :warn  : [  243.417308]  open_last_lookups+0x436/0xeb0
kern  :warn  : [  243.422109]  ? kasan_set_track+0x21/0x30
kern  :warn  : [  243.426738]  path_openat+0x165/0x640
kern  :warn  : [  243.431019]  ? vfs_tmpfile_open+0x60/0x60
kern  :warn  : [  243.435734]  ? filemap_map_pages+0x718/0xb10
kern  :warn  : [  243.440707]  do_filp_open+0x1b1/0x3e0
kern  :warn  : [  243.445080]  ? filemap_map_pmd+0x630/0x630
kern  :warn  : [  243.449886]  ? may_open_dev+0xd0/0xd0
kern  :warn  : [  243.454256]  ? _raw_spin_lock+0x81/0xd0
kern  :warn  : [  243.458807]  ? _raw_write_lock_irq+0xd0/0xd0
kern  :warn  : [  243.463789]  ? alloc_fd+0x3b3/0x560
kern  :warn  : [  243.467981]  do_sys_openat2+0x122/0x400
kern  :warn  : [  243.472524]  ? build_open_flags+0x450/0x450
kern  :warn  : [  243.477413]  __x64_sys_openat+0x11f/0x1d0
kern  :warn  : [  243.482125]  ? __x64_sys_open+0x1a0/0x1a0
kern  :warn  : [  243.486841]  ? exit_to_user_mode_loop+0xbc/0x120
kern  :warn  : [  243.492171]  do_syscall_64+0x35/0x80
kern  :warn  : [  243.496451]  entry_SYSCALL_64_after_hwframe+0x5e/0xc8
kern  :warn  : [  243.502206] RIP: 0033:0x7f727731b5a7
kern  :warn  : [  243.506490] Code: 25 00 00 41 00 3d 00 00 41 00 74 47 64 8b 04 25 18 00 00 00 85 c0 75 6b 44 89 e2 48 89 ee bf 9c ff ff ff b8 01 01 00 00 0f 05 <48> 3d 00 f0 ff ff 0f 87 95 00 00 00 48 8b 4c 24 28 64 48 2b 0c 25
kern  :warn  : [  243.525950] RSP: 002b:00007ffc0dcb7aa0 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
kern  :warn  : [  243.534224] RAX: ffffffffffffffda RBX: 00007ffc0dcb7d58 RCX: 00007f727731b5a7
kern  :warn  : [  243.542057] RDX: 0000000000000941 RSI: 00007ffc0dcb8795 RDI: 00000000ffffff9c
kern  :warn  : [  243.549893] RBP: 00007ffc0dcb8795 R08: 0000000000000000 R09: 0000000000000000
kern  :warn  : [  243.557728] R10: 00000000000001b6 R11: 0000000000000246 R12: 0000000000000941
kern  :warn  : [  243.565570] R13: 00007ffc0dcb8795 R14: 0000000000000000 R15: 0000000000000000
kern  :warn  : [  243.573404]  </TASK>
kern  :alert : [  243.588136] XFS (sda5): Corruption of in-memory data (0x8) detected at xfs_trans_cancel+0x24f/0x580 [xfs] (fs/xfs/xfs_trans.c:1098).  Shutting down filesystem.
kern  :alert : [  243.603268] XFS (sda5): Please unmount the filesystem and rectify the problem(s)
kern  :notice: [  243.758781] XFS (sda5): Unmounting Filesystem
kern  :notice: [  243.944261] XFS (sda2): Unmounting Filesystem
user  :notice: [  244.041371] [failed, exit status 1]- output mismatch (see /lkp/benchmarks/xfstests/results//xfs/076.out.bad)

user  :notice: [  244.060537]     --- tests/xfs/076.out 2022-11-08 10:09:45.000000000 +0000

user  :notice: [  244.073022]     +++ /lkp/benchmarks/xfstests/results//xfs/076.out.bad 2022-11-17 02:46:42.084042859 +0000

user  :notice: [  244.086146]     @@ -1,2 +1,3 @@

user  :notice: [  244.093039]      QA output created by 076

user  :notice: [  244.100648]     -iusepct is in range

user  :notice: [  244.107677]     +fpunch failed

user  :notice: [  244.115509]     +(see /lkp/benchmarks/xfstests/results//xfs/076.full for details)

user  :notice: [  244.126194]     ...


To reproduce:

        git clone https://github.com/intel/lkp-tests.git
        cd lkp-tests
        sudo bin/lkp install job.yaml           # job file is attached in this email
        bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
        sudo bin/lkp run generated-yaml-file

        # if come across any failure that blocks the test,
        # please remove ~/.lkp and /lkp dir to run from a clean state.



-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



View attachment "config-6.1.0-rc1-00031-gbdd2815e0ab1" of type "text/plain" (170376 bytes)

View attachment "job-script" of type "text/plain" (6100 bytes)

Download attachment "kmsg.xz" of type "application/x-xz" (42264 bytes)

View attachment "xfstests" of type "text/plain" (1730 bytes)

View attachment "job.yaml" of type "text/plain" (4942 bytes)

View attachment "reproduce" of type "text/plain" (973 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ