[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4a2836d6-3088-c513-7541-be7c8a0464a5@arm.com>
Date: Mon, 21 Nov 2022 15:13:38 +0000
From: Robin Murphy <robin.murphy@....com>
To: Thomas Gleixner <tglx@...utronix.de>,
LKML <linux-kernel@...r.kernel.org>
Cc: Will Deacon <will@...nel.org>, linux-pci@...r.kernel.org,
Bjorn Helgaas <bhelgaas@...gle.com>,
Marc Zyngier <maz@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jason Gunthorpe <jgg@...lanox.com>,
Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Ammar Faizi <ammarfaizi2@...weeb.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
Santosh Shilimkar <ssantosh@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
Vinod Koul <vkoul@...nel.org>, Sinan Kaya <okaya@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Shameerali Kolothum Thodi
<shameerali.kolothum.thodi@...wei.com>,
Zenghui Yu <yuzenghui@...wei.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>
Subject: Re: [patch V2 02/40] ACPI/IORT: Make prototype of
iort_pmsi_get_dev_id() always available
On 2022-11-21 14:39, Thomas Gleixner wrote:
> W=1 build complains:
>
> drivers/irqchip/irq-gic-v3-its-msi-parent.c:110:12: warning: no previous prototype for function 'iort_pmsi_get_dev_id' [-Wmissing-prototypes]
> int __weak iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id)
>
> Reported-by: Ammar Faizi <ammarfaizi2@...weeb.org>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>
> ---
> include/linux/acpi_iort.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- a/include/linux/acpi_iort.h
> +++ b/include/linux/acpi_iort.h
> @@ -26,13 +26,15 @@ int iort_register_domain_token(int trans
> struct fwnode_handle *fw_node);
> void iort_deregister_domain_token(int trans_id);
> struct fwnode_handle *iort_find_domain_token(int trans_id);
> +
> +int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id);
> +
> #ifdef CONFIG_ACPI_IORT
> void acpi_iort_init(void);
> u32 iort_msi_map_id(struct device *dev, u32 id);
> struct irq_domain *iort_get_device_domain(struct device *dev, u32 id,
> enum irq_domain_bus_token bus_token);
> void acpi_configure_pmsi_domain(struct device *dev);
> -int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id);
FWIW I'd prefer to add a "return -ENODEV" stub in the #else section to
match the others.
<wonders why this was inconsistent to begin with, goes off to dig
through Git history...>
Oh hey, then we could also finally make good on that 6-year-old promise
that "The weak function will be removed when the ACPI counterpart is
merged." :)
Thanks,
Robin.
> void iort_get_rmr_sids(struct fwnode_handle *iommu_fwnode,
> struct list_head *head);
> void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode,
>
Powered by blists - more mailing lists