linux-kernel - Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09ac46a0-45fe-e280-cabb-682e05c7fddc@redhat.com>
Date:   Mon, 21 Nov 2022 10:32:17 -0500
From:   Joe Lawrence <joe.lawrence@...hat.com>
To:     Song Liu <song@...nel.org>
Cc:     live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
        jpoimboe@...nel.org, jikos@...nel.org, mbenes@...e.cz,
        x86@...nel.org, linuxppc-dev@...ts.ozlabs.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v6] livepatch: Clear relocation targets on a module
 removal

On 11/18/22 12:14 PM, Song Liu wrote:
> Hi Petr,
> 
> On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek <pmladek@...e.com> wrote:
>>
>> On Thu 2022-09-01 10:12:52, Song Liu wrote:
> [...]
>>>
>>>  arch/powerpc/kernel/module_32.c |  10 ++++
>>>  arch/powerpc/kernel/module_64.c |  49 +++++++++++++++
>>>  arch/s390/kernel/module.c       |   8 +++
>>>  arch/x86/kernel/module.c        | 102 +++++++++++++++++++++++---------
>>>  include/linux/moduleloader.h    |   7 +++
>>>  kernel/livepatch/core.c         |  41 ++++++++++++-
>>
>> First, thanks a lot for working on this.
>>
>> I can't check or test the powerpc and s390 code easily.
>>
>> I am going to comment only x86 and generic code. It looks good
>> but it needs some changes to improve maintainability.
> 
> Thanks for these comments and suggestions. I will work on them
> and send v4.
> 

Hi Song,

I'll help with testing the arches (at least ppc64le and s390x, I can
only cross-build ppc32).  I can either pick up the patches from the list
when you post, or if you want to run them through testing first, lmk.

Thanks,

-- 
Joe