[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y3ufKdApJGj6f97b@shell.armlinux.org.uk>
Date: Mon, 21 Nov 2022 15:54:17 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] drm/armada: Fix off-by-one error in
armada_overlay_get_property()
On Mon, Nov 21, 2022 at 04:43:14PM +0100, Geert Uytterhoeven wrote:
> As ffs() returns one more than the index of the first bit set (zero
> means no bits set), the color key mode value is shifted one position too
> much.
>
> Fix this by using FIELD_GET() instead.
Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists