linux-kernel - [PATCH] media: i2c: ov08x40: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 17:34:47 +0000
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     linux-media@...r.kernel.org
Cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Jason Chen <jason.z.chen@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Ajay Gupta <ajayg@...dia.com>,
        Marek Behún <kabel@...nel.org>,
        Peter Rosin <peda@...ntia.se>, Petr Machata <petrm@...dia.com>,
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] media: i2c: ov08x40: Make remove callback return void

In commit ed5c2f5fd10d ("i2c: Make remove callback return void") drivers
were updated to remove the return value of the remove callback, and
return void.

The OV08x40 was not able to be compile tested at the time due to a
KConfig issue, and was missed.

Now that the OV08x40 is able to be selected, update the driver
accordingly.

Fixes: ed5c2f5fd10d ("i2c: Make remove callback return void")
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
---
 drivers/media/i2c/ov08x40.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c
index b4ade17a83f5..72ae7fba94eb 100644
--- a/drivers/media/i2c/ov08x40.c
+++ b/drivers/media/i2c/ov08x40.c
@@ -3281,7 +3281,7 @@ static int ov08x40_probe(struct i2c_client *client)
 	return ret;
 }
 
-static int ov08x40_remove(struct i2c_client *client)
+static void ov08x40_remove(struct i2c_client *client)
 {
 	struct v4l2_subdev *sd = i2c_get_clientdata(client);
 	struct ov08x40 *ov08x = to_ov08x40(sd);
@@ -3292,8 +3292,6 @@ static int ov08x40_remove(struct i2c_client *client)
 
 	pm_runtime_disable(&client->dev);
 	pm_runtime_set_suspended(&client->dev);
-
-	return 0;
 }
 
 static const struct dev_pm_ops ov08x40_pm_ops = {
-- 
2.34.1