lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3u6iSiJOgcy38cL@boxer>
Date:   Mon, 21 Nov 2022 18:51:05 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     Roger Quadros <rogerq@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "vigneshr@...com" <vigneshr@...com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove
 redundant ALE_CLEAR

On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote:
> ALE_CLEAR command is issued in cpsw_ale_start() so no need
> to issue it before the call to cpsw_ale_start().
> 
> Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support")

Not a fix to me, can you send it to -next tree? As you said, it's an
optimization.

> Signed-off-by: Roger Quadros <rogerq@...nel.org>
> ---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 505c9edf98ff..2acde5b14516 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -404,7 +404,6 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
>  	/* disable priority elevation */
>  	writel(0, common->cpsw_base + AM65_CPSW_REG_PTYPE);
>  
> -	cpsw_ale_control_set(common->ale, 0, ALE_CLEAR, 1);
>  	cpsw_ale_start(common->ale);
>  
>  	/* limit to one RX flow only */
> -- 
> 2.17.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ