[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221121185042.GA15225@blackbody.suse.cz>
Date: Mon, 21 Nov 2022 19:50:42 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Waiman Long <longman@...hat.com>
Cc: Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>,
Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
linux-kernel@...r.kernel.org,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH 2/2] cgroup/cpuset: Optimize cpuset_attach() on v2
On Sat, Nov 12, 2022 at 05:19:39PM -0500, Waiman Long <longman@...hat.com> wrote:
> + /*
> + * In the default hierarchy, enabling cpuset in the child cgroups
> + * will trigger a number of cpuset_attach() calls with no change
> + * in effective cpus and mems. In that case, we can optimize out
> + * by skipping the task iteration and update.
> + */
> + if (cgroup_subsys_on_dfl(cpuset_cgrp_subsys) &&
> + !cpus_updated && !mems_updated) {
I'm just wondering -- why is this limited to the default hierarchy only?
IOW why can't v1 skip too (when favorable constness between cpusets).
Thanks,
Michal
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists