linux-kernel - Re: [PATCH v2] btrfs: rcu_string: Replace strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221121185427.GB5824@twin.jikos.cz>
Date:   Mon, 21 Nov 2022 19:54:27 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Artem Chernyshev <artem.chernyshev@...-soft.ru>
Cc:     Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
        Josef Bacik <josef@...icpanda.com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] btrfs: rcu_string: Replace strncpy() with strscpy()

On Sat, Nov 19, 2022 at 11:13:29AM +0300, Artem Chernyshev wrote:
> Using strncpy() on NUL-terminated strings are deprecated.
> To avoid possible forming of non-terminated string
> strscpy() could be used.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 606686eeac45 ("Btrfs: use rcu to protect device->name")
> Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru>

Added to misc-next, thanks. There's one last strncpy in
btrfs_ioctl_dev_info if you also want to convert it. The rest is strcpy
from static strings.