linux-kernel - Re: [PATCH] test_firmware: fix memory leak in test_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3vQHTZpjNijVjiM@bombadil.infradead.org>
Date:   Mon, 21 Nov 2022 11:23:09 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        russell.h.weight@...el.com, tianfei.zhang@...el.com,
        error27@...il.com, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH] test_firmware: fix memory leak in test_firmware_init()

On Sat, Nov 19, 2022 at 11:57:21AM +0800, Zhengchao Shao wrote:
> When misc_register() failed in test_firmware_init(), the memory pointed
> by test_fw_config->name is not released. The memory leak information is
> as follows:
> unreferenced object 0xffff88810a34cb00 (size 32):
>   comm "insmod", pid 7952, jiffies 4294948236 (age 49.060s)
>   hex dump (first 32 bytes):
>     74 65 73 74 2d 66 69 72 6d 77 61 72 65 2e 62 69  test-firmware.bi
>     6e 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  n...............
>   backtrace:
>     [<ffffffff81b21fcb>] __kmalloc_node_track_caller+0x4b/0xc0
>     [<ffffffff81affb96>] kstrndup+0x46/0xc0
>     [<ffffffffa0403a49>] __test_firmware_config_init+0x29/0x380 [test_firmware]
>     [<ffffffffa040f068>] 0xffffffffa040f068
>     [<ffffffff81002c41>] do_one_initcall+0x141/0x780
>     [<ffffffff816a72c3>] do_init_module+0x1c3/0x630
>     [<ffffffff816adb9e>] load_module+0x623e/0x76a0
>     [<ffffffff816af471>] __do_sys_finit_module+0x181/0x240
>     [<ffffffff89978f99>] do_syscall_64+0x39/0xb0
>     [<ffffffff89a0008b>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
> 
> Fixes: c92316bf8e94 ("test_firmware: add batched firmware tests")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Acked-by: Luis Chamberlain <mcgrof@...nel.org>

  Luis