linux-kernel - Re: [PATCH v2 5/5] clk: imx8mn: fix imx8mn_enet_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3vep1zwBikjsB0R@linaro.org>
Date:   Mon, 21 Nov 2022 22:25:11 +0200
From:   Abel Vesa <abel.vesa@...aro.org>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc:     linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com,
        michael@...rulasolutions.com, Abel Vesa <abelvesa@...nel.org>,
        Anson Huang <Anson.Huang@....com>,
        Fabio Estevam <festevam@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 5/5] clk: imx8mn: fix imx8mn_enet_phy_sels clocks list

On 22-11-17 12:36:37, Dario Binacchi wrote:
> According to the "Clock Root" table of the reference manual (document
> IMX8MNRM Rev 2, 07/2022):
> 
>      Clock Root         offset     Source Select (CCM_TARGET_ROOTn[MUX])
>         ...              ...                    ...
>  ENET_PHY_REF_CLK_ROOT  0xAA80            000 - 24M_REF_CLK
>                                           001 - SYSTEM_PLL2_DIV20
>                                           010 - SYSTEM_PLL2_DIV8
>                                           011 - SYSTEM_PLL2_DIV5
>                                           100 - SYSTEM_PLL2_DIV2
>                                           101 - AUDIO_PLL1_CLK
>                                           110 - VIDEO_PLL_CLK
>                                           111 - AUDIO_PLL2_CLK
>         ...              ...                    ...
> 
> while the imx8mn_enet_phy_sels list didn't contained audio_pll1_out for
> source select bits 101b.
> 
> Fixes: 96d6392b54dbb ("clk: imx: Add support for i.MX8MN clock driver")
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>

Reviewed-by: Abel Vesa <abel.vesa@...aro.org>

> 
> ---
> 
> (no changes since v1)
> 
>  drivers/clk/imx/clk-imx8mn.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 37128c35198d..2afea905f7f3 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -140,8 +140,8 @@ static const char * const imx8mn_enet_timer_sels[] = {"osc_24m", "sys_pll2_100m"
>  						      "clk_ext4", "video_pll_out", };
>  
>  static const char * const imx8mn_enet_phy_sels[] = {"osc_24m", "sys_pll2_50m", "sys_pll2_125m",
> -						    "sys_pll2_200m", "sys_pll2_500m", "video_pll_out",
> -						    "audio_pll2_out", };
> +						    "sys_pll2_200m", "sys_pll2_500m", "audio_pll1_out",
> +						    "video_pll_out", "audio_pll2_out", };
>  
>  static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
>  						"sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> -- 
> 2.32.0
>