linux-kernel - Re: [PATCH RESEND] panic: Add register_panic_notifier and unregister_panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 13:57:08 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Xu Qiang <xuqiang36@...wei.com>
Cc:     <pmladek@...e.com>, <mcgrof@...nel.org>, <elver@...gle.com>,
        <gpiccoli@...lia.com>, <bigeasy@...utronix.de>,
        <tangmeng@...ontech.com>, <andriy.shevchenko@...ux.intel.com>,
        <yangtiezhu@...ngson.cn>, <john.ogness@...utronix.de>,
        <daniel.vetter@...ll.ch>, <linux-kernel@...r.kernel.org>,
        <weiyongjun1@...wei.com>
Subject: Re: [PATCH RESEND] panic: Add register_panic_notifier and
 unregister_panic_notifier

On Sat, 19 Nov 2022 08:03:05 +0000 Xu Qiang <xuqiang36@...wei.com> wrote:

> Add two methods to manipulate panic_notifier_list and export them.
> Subsequently, panic_notifier_list is changed to static variable.

Fair enough, I guess.  But...

- It would be better to include a followup patch which converts at
  least some of the existing sites, so we know the code is getting
  tested.

- Better names would be panic_notifier_register() and
  panic_notifier_unregister()

- You forgot to make panic_notifier_list static to panic.c.