linux-kernel - Re: [PATCH bpf-next] docs/bpf: Update btf selftests program and add link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3so8nndjYTpRVHn@maniforge.lan>
Date:   Mon, 21 Nov 2022 01:29:54 -0600
From:   David Vernet <void@...ifault.com>
To:     Rong Tao <rtoax@...mail.com>
Cc:     andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
        corbet@....net, daniel@...earbox.net, haoluo@...gle.com,
        john.fastabend@...il.com, jolsa@...nel.org, kpsingh@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        martin.lau@...ux.dev, rongtao@...tc.cn, sdf@...gle.com,
        song@...nel.org, yhs@...com
Subject: Re: [PATCH bpf-next] docs/bpf: Update btf selftests program and add
 link

On Mon, Nov 21, 2022 at 10:07:34AM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@...tc.cn>
> 
> commit c64779e24e88("selftests/bpf: Merge most of test_btf into
> test_progs") rename selftests/bpf btf test from 'test_btf.c' to
> 'prog_tests/btf.c'.
> 
> Signed-off-by: Rong Tao <rongtao@...tc.cn>
> ---

Please send this out as a v2 patch, as described in [0].

[0]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

>  Documentation/bpf/btf.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
> index cf8722f96090..dca0b0e9dd35 100644
> --- a/Documentation/bpf/btf.rst
> +++ b/Documentation/bpf/btf.rst
> @@ -1062,4 +1062,9 @@ format.::
>  7. Testing
>  ==========
>  
> -Kernel bpf selftest `test_btf.c` provides extensive set of BTF-related tests.
> +Kernel bpf selftest `tools/testing/selftests/bpf/prog_tests/btf.c`_ provides

You added the hyperlink, but don't seem to have applied my other
suggestions. Please do so in v2.

> +extensive set of BTF-related tests.
> +
> +.. Links
> +.. _tools/testing/selftests/bpf/prog_tests/btf.c:
> +   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/tools/testing/selftests/bpf/prog_tests/btf.c
> -- 
> 2.38.1
>