linux-kernel - Re: [PATCH] ubifs: Fix build errors as symbol undefined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 09:00:02 +0100 (CET)
From:   Richard Weinberger <richard@....at>
To:     Lihua <hucool.lihua@...wei.com>
Cc:     Sascha Hauer <s.hauer@...gutronix.de>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        yusongping <yusongping@...wei.com>
Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined

----- Ursprüngliche Mail -----
> Von: "Lihua" <hucool.lihua@...wei.com>
> An: "richard" <richard@....at>
> CC: "Sascha Hauer" <s.hauer@...gutronix.de>, "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>, "Wei Yongjun" <weiyongjun1@...wei.com>, "yusongping" <yusongping@...wei.com>
> Gesendet: Montag, 21. November 2022 02:54:53
> Betreff: Re: [PATCH] ubifs: Fix build errors as symbol undefined

> You can verify it with the config in the attachment. TKS :D

Thanks for your .config, I was able to identify the problem.
When CONFIG_CC_OPTIMIZE_FOR_SIZE is set the compiler does not optimize this construct:

        err = ubifs_node_check_hash(c, buf, zbr->hash);
        if (err) {
                ubifs_bad_hash(c, buf, zbr->hash, lnum, offs);
                return 0;
        }

With CONFIG_UBIFS_FS_AUTHENTICATION not set, the compiler can assume that
ubifs_node_check_hash() is never true and drops the call to ubifs_bad_hash().
Is CONFIG_CC_OPTIMIZE_FOR_SIZE enabled this optimization does not happen anymore.

So we need a no-op ubifs_bad_hash() for the CONFIG_UBIFS_FS_AUTHENTICATION=n case.

Thanks,
//richard