[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3s/0GsGvospVc+G@kuha.fi.intel.com>
Date: Mon, 21 Nov 2022 11:07:28 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Uwe Kleine-König <uwe@...ine-koenig.org>
Cc: Angel Iglesias <ang.iglesiasg@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Grant Likely <grant.likely@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-i2c@...r.kernel.org, kernel@...gutronix.de,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 580/606] usb: typec: tcpm/tcpci: Convert to i2c's
.probe_new()
On Fri, Nov 18, 2022 at 11:45:14PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index b2bfcebe218f..d3efb9665901 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -807,8 +807,7 @@ void tcpci_unregister_port(struct tcpci *tcpci)
> }
> EXPORT_SYMBOL_GPL(tcpci_unregister_port);
>
> -static int tcpci_probe(struct i2c_client *client,
> - const struct i2c_device_id *i2c_id)
> +static int tcpci_probe(struct i2c_client *client)
> {
> struct tcpci_chip *chip;
> int err;
> @@ -878,7 +877,7 @@ static struct i2c_driver tcpci_i2c_driver = {
> .name = "tcpci",
> .of_match_table = of_match_ptr(tcpci_of_match),
> },
> - .probe = tcpci_probe,
> + .probe_new = tcpci_probe,
> .remove = tcpci_remove,
> .id_table = tcpci_id,
> };
thanks,
--
heikki
Powered by blists - more mailing lists