linux-kernel - Re: [PATCH 431/606] mfd: khadas-mcu: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <929e06bf-84b5-047f-91e9-29876b721cee@linaro.org>
Date:   Mon, 21 Nov 2022 10:56:50 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Lee Jones <lee@...nel.org>
Cc:     linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 431/606] mfd: khadas-mcu: Convert to i2c's .probe_new()

On 18/11/2022 23:42, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>   drivers/mfd/khadas-mcu.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c
> index f3d418810693..7338cc16f327 100644
> --- a/drivers/mfd/khadas-mcu.c
> +++ b/drivers/mfd/khadas-mcu.c
> @@ -84,8 +84,7 @@ static struct mfd_cell khadas_mcu_cells[] = {
>   	{ .name = "khadas-mcu-user-mem", },
>   };
>   
> -static int khadas_mcu_probe(struct i2c_client *client,
> -		       const struct i2c_device_id *id)
> +static int khadas_mcu_probe(struct i2c_client *client)
>   {
>   	struct device *dev = &client->dev;
>   	struct khadas_mcu *ddata;
> @@ -135,7 +134,7 @@ static struct i2c_driver khadas_mcu_driver = {
>   		.name = "khadas-mcu-core",
>   		.of_match_table = of_match_ptr(khadas_mcu_of_match),
>   	},
> -	.probe = khadas_mcu_probe,
> +	.probe_new = khadas_mcu_probe,
>   };
>   module_i2c_driver(khadas_mcu_driver);
>   


Acked-by: Neil Armstrong <neil.armstrong@...aro.org>